Fix caret position in web when deleting forward with no characters selected #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rafecolton
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Change LGTM, I tested it on dev. @ishpaul777 can you do the full testing here that you'd normally do on an App PR, then we can move the checklist over when @QichenZhu bumps the version there?
ishpaul777
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The caret is in the wrong position after deleting forward with no characters selected.
Related Issues
Expensify/App#48797
Proposal: Expensify/App#48797 (comment)
Manual Tests
Deletekey.Expected result: The caret position does not change.
Videos
Before this fix
before.mov
After this fix
after.mov
Linked PRs