Use NSTextStorageDelegate instead of method swizzling

[tomekzaw]

Details

Work in progress.

This PR is supposed to fix these issues:

• Spellcheck for previous words gets removed while typing on iOS #34
• Use ISA swizzling instead of method swizzling on iOS #102
• Migrate away from TextKit 1 to TextKit 2 #145
• Backticks are not removed when entering diacritics using option key commands on iOS #181
• Migrate from NSRange to UITextRange on iOS #191
• Cannot select single words on first attempt in text with headings or blockquotes on iOS #417
• Can't input some other language, such as Chinese #452
• Font size doesn't change immediately when updating styles on iOS #540

Related Issues

GH_LINK

Manual Tests

Linked PRs

[tomekzaw]

Regression: Cursor is shifted to the right when adding a newline after a blockquote

Screen.Recording.2024-10-17.at.11.38.34.mov

[tomekzaw]

Bug: spellcheck completely disappears when adding Markdown syntax

Screen.Recording.2024-10-21.at.20.50.18.mov

[tomekzaw]

Regression: Emojis are not visible

edit: [attributedString addAttributes:defaultTextAttributes range:fullRange]; breaks emoji font

edit2: fixed in 67968ec and explained better in 6e40703

[tomekzaw]

Regression: toggling text color doesn't work (it only works when you toggle markdownStyle first)

edit: it works if text doesn't contain any emojis

edit2: fixed in d377043 and explained better in 6e40703

[j-piasecki]

🪨 🪨

[tomekzaw]

TODO: confirm that removing NSOriginalFont doesn't break anything (like copying text with emojis from MarkdownTextInput)

react-native-live-markdown/apple/RCTMarkdownUtils.mm

Lines 66 to 74 in 1fa1b54

	/*
	When updating MarkdownTextInput's `style` property without changing `markdownStyle`,
	React Native calls `[RCTTextInputComponentView _setAttributedString:]` which skips update if strings are equal.
	See https://github.com/facebook/react-native/blob/287e20033207df5e59d199a347b7ae2b4cd7a59e/packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm#L680-L684
	The attributed strings are compared using `[RCTTextInputComponentView _textOf:equals:]` which compares only raw strings
	if NSOriginalFont attribute is present. So we purposefully remove this attribute to force update.
	See https://github.com/facebook/react-native/blob/287e20033207df5e59d199a347b7ae2b4cd7a59e/packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm#L751-L784
	*/
	[attributedString removeAttribute:@"NSOriginalFont" range:fullRange];

[289Adam289]

Bug IOS: removing multiline prop breaks markdown formatting

Screen.Recording.2024-11-18.at.13.09.20.mov

Reproduction steps:

1. Remove multiline prop
2. Verify that markdown formatting does not work and flickers while using input
3. Pass multiline prop again
4. Notice that formatting is still broken

[289Adam289]

Bugs mentioned in #520 (comment) and #520 (comment) are still reproducible

[289Adam289]

Bugs IOS E/App:

1. Content jump when using block quote

Screen.Recording.2024-11-18.at.16.41.41.mov

2. Last character moves when using header:

Screen.Recording.2024-11-18.at.16.46.39.mov

3. Red dotted line appears and immediately disappears:

Screen.Recording.2024-11-18.at.16.49.13.mov

[289Adam289]

I've tested this pr on example app on all platforms and directly in Expensify App on all platforms and I could not find more bugs or issues.

[tomekzaw]

#520 (comment) should be fixed in 1c432fe

Screen.Recording.2024-11-20.at.16.42.28.mov

[tomekzaw]

As for bug mentioned in #520 (comment), this also happens on main so it's not an regression:

main	this PR
Screen.Recording.2024-11-20.at.16.34.50.mov	Screen.Recording.2024-11-20.at.16.43.38.mov

Similarly for #520 (comment), the behavios is same as on main:

main	this PR
Screen.Recording.2024-11-20.at.16.33.31.mov	Screen.Recording.2024-11-20.at.16.49.37.mov

[tomekzaw]

Bug: after removing blockquote, the cursor is shifted to the right and overlays the placeholder

Screen.Recording.2024-11-20.at.18.10.33.mov

[tomekzaw]

#520 (comment) should be fixed with c00c440

Screen.Recording.2024-11-26.at.17.23.19.mov