Fix a bug where full state was being passed to a withOnyx selector #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
joelbettner
and removed request for
a team
tgolen
commented
Oct 28, 2022
| @@ -16,6 +16,23 @@ Onyx.init({ | |||
| registerStorageEventListener: () => {}, | |||
| }); | |||
|
|
|||
| class ErrorBoundary extends React.Component { | |||
There was a problem hiding this comment.
@marcaaron I ran into more cases where if there is a syntax error inside the selector function, then Jest isn't able to catch and report it.
marcaaron
approved these changes
Oct 28, 2022
93 tasks
|
@joelbettner bump for review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There was this code that was passing the entire state object to the selector. That's wrong. Instead, it should only be passing the piece of state that the withOnyx mapping is working with.
cc @marcaaron
Related Issues
Fixes an issue I found while testing Expensify/App#12083
Automated Tests
Covered by automated tests