-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD sqllite deployed to production] Add functionality for multiRemove() #219
Conversation
Should we also add a basic test for the |
Thanks @yuwenmemon for the review! I did add a couple of basic tests for |
Co-authored-by: Yuwen Memon <yuwen@expensify.com>
Co-authored-by: Yuwen Memon <yuwen@expensify.com>
Co-authored-by: Yuwen Memon <yuwen@expensify.com>
I think that's fair. My only thought was maybe adding tests similar to what we have for clear() and multiMerge(). But looks like both of those are meant to check for regressions for some more esoteric cache behavior. Also sorry for screwing you on the line indentation with my suggestions 😅 |
OK, I've actually been working on this second PR that fixes Expensify/App#13884 and it looks like we aren't going to need |
Related Issues
Fixes https://github.com/Expensify/Expensify/issues/251798
Automated Tests
I added some, but it's difficult to test this fully with both data providers. I tested this by adding it to App and testing that signin/singout worked (especially on a large account)
Linked PRs
Expensify/App#13886