Add memoryOnlyKeys setter option to Onyx
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
jasperhuangg
and removed request for
a team
58 tasks
AndrewGable
requested review from
AndrewGable
and removed request for
jasperhuangg
|
Tested here: Expensify/App#22729 (comment) |
AndrewGable
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Guides continue to experience really bad performance that we now know is in part related to the IndexedDB code and the synchronous setting of each key one at a time. This is a performance improvement with smaller data sets, but ends up creating a ton of blocking time when these datasets are large.
Related Issues
Expensify/App#21766
Automated Tests
Since this is an opt-in behavior and bandaid solution for now I didn't write any tests.
Linked PRs
Expensify/App#22729