Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve promise when onyx update collection has wrong key #273

Closed
wants to merge 1 commit into from
Closed

Resolve promise when onyx update collection has wrong key #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/Onyx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,13 +1129,18 @@ function mergeCollection(collectionKey, collection) {
}

// Confirm all the collection keys belong to the same parent
let collectionKeyCheckPassed = true;
_.each(collection, (_data, dataKey) => {
if (isKeyMatch(collectionKey, dataKey)) {
return;
}

throw new Error(`Provided collection doesn't have all its data belonging to the same parent. CollectionKey: ${collectionKey}, DataKey: ${dataKey}`);
Logger.logInfo(`Provided collection doesn't have all its data belonging to the same parent. CollectionKey: ${collectionKey}, DataKey: ${dataKey}`);
collectionKeyCheckPassed = false;
});
if (!collectionKeyCheckPassed) {
return Promise.resolve();
}

return getAllKeys()
.then((persistedKeys) => {
Expand Down