Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw in dev if collection keys don't belong to the same parent #277

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Jul 13, 2023

Details

Coming from this comment, we should make the error easier to catch on dev by throwing it, instead of logging.

cc @marcaaron @mountiny

Related Issues

https://github.com/Expensify/react-native-onyx/pull/272/files#r1261673744

Automated Tests

N/A

Linked PRs

TBD

@luacmartins luacmartins requested a review from a team as a code owner July 13, 2023 15:44
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team July 13, 2023 15:45
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me

@mountiny
Copy link
Contributor

I think we can go ahead with this one as its late for Vivek and Marc has proposed this change before

@mountiny mountiny merged commit 43d23e8 into main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants