Revert pull request #353 remove-nested-nullish-object-keys #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
techievivek
and removed request for
a team
marcaaron
approved these changes
Sep 29, 2023
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8671b9c, reversing changes made to ce35c4e.
Details
This commit broke tests in the main app as seen in when I tried to bump onyx. Merged on this PR
More over it caused an exception on the sqlite layer, which causes a crash on app start.
I don't know the context of the changes but they seem convoluted, so in order to unblock my PR with a simple fix I'm reverting this merge for now.
Related Issues
Expensify/App#28440
Automated Tests
Linked PRs