Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nested null values in objects (after revert) #380

Merged
merged 30 commits into from
Oct 4, 2023
Merged

Remove nested null values in objects (after revert) #380

merged 30 commits into from
Oct 4, 2023

Conversation

chrispader
Copy link
Contributor

@chrispader chrispader commented Sep 29, 2023 •
edited
Loading

@marcaaron @blazejkustra @tgolen

Details

Original PR got reverted because of failing tests.

This PR fixes tests and improves consistency by also applying changes to multiSet and mergeCollection.

Failing tests in Expensify/App are fixed here

Related Issues

GH_LINK

Automated Tests

Linked PRs

@chrispader chrispader changed the title Remove nested null values in objects (2) Remove nested null values in objects (after revert) Oct 2, 2023
@chrispader chrispader marked this pull request as ready for review October 2, 2023 12:33
@chrispader chrispader requested a review from a team as a code owner October 2, 2023 12:33
@melvin-bot melvin-bot bot requested review from hayata-suenaga and removed request for a team October 2, 2023 12:33
@hayata-suenaga hayata-suenaga requested review from tgolen, neil-marcellini and marcaaron and removed request for hayata-suenaga October 3, 2023 03:54
@hayata-suenaga
Copy link
Contributor

Assigning the original reviewers or the reverted PR 🙇

tgolen
tgolen previously approved these changes Oct 3, 2023
View reviewed changes
lib/Onyx.js Outdated Show resolved Hide resolved
lib/Onyx.js Outdated Show resolved Hide resolved
lib/Onyx.js Outdated Show resolved Hide resolved
lib/Onyx.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
tests/unit/onyxTest.js Outdated Show resolved Hide resolved
lib/Onyx.js Show resolved Hide resolved
@chrispader chrispader requested a review from tgolen October 3, 2023 15:30
tgolen
tgolen approved these changes Oct 3, 2023
View reviewed changes
lib/utils.js Show resolved Hide resolved
neil-marcellini
neil-marcellini approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me🤞

@tgolen tgolen merged commit c6ad4b5 into Expensify:main Oct 4, 2023
3 checks passed
@ospfranco ospfranco mentioned this pull request Oct 10, 2023
Merged
59 tasks
@arosiclair arosiclair mentioned this pull request Nov 10, 2023
Closed
@chrispader chrispader mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgolen tgolen tgolen approved these changes

@neil-marcellini neil-marcellini neil-marcellini approved these changes

@marcaaron marcaaron Awaiting requested review from marcaaron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrispader @hayata-suenaga @tgolen @neil-marcellini