Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Skip a write to storage when nothing is actually changing #92

Merged
merged 1 commit into from
Jul 29, 2021
Merged

perf: Skip a write to storage when nothing is actually changing #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Onyx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,11 @@ function evictStorageAndRetry(error, ionMethod, ...args) {
* @returns {Promise}
*/
function set(key, val) {
// Skip writing to storage if the value hasn't changed
if (cache.hasCacheForKey(key) && _.isEqual(val, cache.getValue(key))) {
return Promise.resolve();
}

// Adds the key to cache when it's not available
cache.set(key, val);

Expand Down