Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Update CustomPickerProps and Icon types #15

Merged

Conversation

VickyStash
Copy link

Description

The lack of Picker typing was noticed during the Expensify app Picker migration to the TypeScript. This PR resolve the TS issues that was defined during the Picker migration:

Related Issues

$ Expensify/App#25091

index.d.ts Outdated Show resolved Hide resolved
@VickyStash VickyStash marked this pull request as ready for review November 3, 2023 09:56
Copy link

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense!

@mountiny mountiny merged commit 0d15d46 into Expensify:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants