Fixed the mweb safari popup picker cannot be full screen when the keyboard is displayed #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…board is displayed
6 tasks
|
@s77rt - Can you comment here so I can assign you for review too? Thanks! |
|
Sure |
|
Weird - Doesn't look like I can assign you, but just double checking this looks good for your review? Then we can pull this change into package.json and do our checklist on the App PR. |
|
Yes the change looks good to me. |
AndrewGable
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Expensify/App#16081
Proposal: Expensify/App#16081 (comment)
C+ Review: Expensify/App#16081 (comment)
Expensify Review: Expensify/App#16081 (comment)
When the keyboard is displayed, mwebSafari pops up a new picker and cannot calculate the correct screen height, causing the picker to not be full screen
We
dismissthe keyboard in theonPointerUpfirst, and then the page can correctly display the size of the picker