Update the PR template to include a higher bar for quality #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
approved these changes
Jan 19, 2023
|
@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
This integration should probably not be enabled in this repo because we do not have it properly configured to run Facebook's CI, so tests always fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many of the PRs in this fork do not follow the PR template and don't fill in the mandatory fields. They also rarely contain information about the corresponding upstream PR in a consistent manner which makes finding the upstream PR very difficult which makes upgrading versions of RN very difficult.
Changelog
[Internal] [Added] - Added an upstream PR field to the PR template
Test Plan
This can only be tested after this PR is merged.