fundamentals material: Make links open in new tabs #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the older material, links still open in the current browser window which causes the user to navigate away from the PECA player. This is confusing and can break the learning experience. Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
gkunz
force-pushed
the
links-blank-targets
branch
from
e74884f
to
05afdfe
Compare
YasinAhmed2
approved these changes
May 8, 2024
There was a problem hiding this comment.
I have not been part of the Fundamentals Coarse. I checked the PECA player. I agree the changes would make the learning experience much better by not moving away from the coarse material.
Very good keeping the original page open while allowing users to explore linked page outside.
I did not review the content otherwise. Ok, to merge from side.
| @@ -24,7 +24,7 @@ Such strategy or policy might also be needed on product or product area level. | |||
|
|
|||
|  | |||
|
|
|||
| _Image by [Randall Munroe](https://xkcd.com/2347/)_ | |||
| _Image by [Randall Munroe](https://xkcd.com/2347/){:target="_blank"}_ | |||
|
|
|||
There was a problem hiding this comment.
Very good keeping the original page open while allowing readers to explore linked page outside.
| @@ -88,7 +88,7 @@ Documentation to declare included free open source software components as either | |||
|
|
|||
| Suggested formats are being developed both for general consumption and for industry niches like automotive, health and telecom. There is a standard for the data format (SPDX) for this in place. ISO/IEC 5962:2021 | |||
|
|
|||
| [Link to NTIA requirements on SBOMs >>](https://www.ntia.doc.gov/report/2021/minimum-elements-software-bill-materials-sbom) | |||
| [Link to NTIA requirements on SBOMs >>](https://www.ntia.doc.gov/report/2021/minimum-elements-software-bill-materials-sbom){:target="_blank"} | |||
There was a problem hiding this comment.
Very good keeping the original page open while allowing readers to explore linked page outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the older material, links still open in the current browser window which causes the user to navigate away from the PECA player. This is confusing and can break the learning experience.