Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hidden command that shows project version #131

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

siderai
Copy link
Contributor

@siderai siderai commented Jul 14, 2023

Checklist

  • I've generated a new bot from the bot-template and checked that everything works:
    • Linters and tests have passed
    • Bot answers on /help command
    • Bot suggests available commands
  • I've written good commit message for all commits
  • I've split changes into separate commits where it's appropriate
  • I'll make a release when PR is approved

Использовал subprocess.run вместо os.system, поскольку в последнем случае нельзя вернуть stdout.

Хотелось бы, чтобы эту фичу было легко притащить в уже существующие проекты, а также чтобы она работала при локальной разработке. Поэтому решил не задействовать пайплайн.

P.S. в copier подняли версию pydantic до v2 и сломали проект. Пришлось временно захардкодить версии

@siderai siderai force-pushed the feat/hidden-command-for-project-version branch 15 times, most recently from eee18a2 to 67abfaa Compare July 15, 2023 12:45
@siderai siderai force-pushed the feat/hidden-command-for-project-version branch from 67abfaa to 6db654b Compare July 15, 2023 12:51
@siderai siderai merged commit b6110d8 into master Jul 17, 2023
@siderai siderai deleted the feat/hidden-command-for-project-version branch July 17, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants