Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write bytes to csv file to avoid utf-8 decode error #441

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

alexhook
Copy link
Member

@alexhook alexhook commented Jan 6, 2024

PR checklist

  • I've written good commit message for all commits
  • I've split changes into separate commits where it's appropriate
  • I've added the description of function to documentation
  • I've updated project version in pyproject.toml
  • I'll make a release when PR is merged
  • I'll bump pybotx in bot-template

@alexhook alexhook force-pushed the fix/user-as-csv-can-not-decode-bytes branch from dc9f961 to ca5f8b0 Compare January 6, 2024 08:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d11b47e) 100.00% compared to head (6277da8) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #441   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         3845      3846    +1     
  Branches       331       333    +2     
=========================================
+ Hits          3845      3846    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexhook alexhook force-pushed the fix/user-as-csv-can-not-decode-bytes branch from ca5f8b0 to 6277da8 Compare January 6, 2024 13:32
@alexhook alexhook changed the title fix: set chunk size for user_as_csv request stream to avoid utf-8 decode error fix: write bytes to csv file to avoid utf-8 decode error Jan 6, 2024
@alexhook alexhook merged commit b7f87f5 into master Jan 9, 2024
6 checks passed
@alexhook alexhook deleted the fix/user-as-csv-can-not-decode-bytes branch January 9, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants