Do not pass user defines when in manual mode. Closes #602

ExpressLRS · Jun 19, 2024 · 7ce7725 · 7ce7725 · davetheghost · Sep 15, 2024
1 parent 8fb8ec1
commit 7ce7725
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/api/src/services/BinaryFlashingStrategy/BinaryConfigurator/index.ts b/src/api/src/services/BinaryFlashingStrategy/BinaryConfigurator/index.ts
@@ -5,6 +5,7 @@ import UserDefineKey from '../../../library/FirmwareBuilder/Enum/UserDefineKey';
 import { NoOpFunc, OnOutputFunc } from '../../../library/Commander';
 import Python from '../../../library/Python';
 import { LoggerService } from '../../../logger';
+import UserDefinesMode from '../../../models/enum/UserDefinesMode';
 
 const maskSensitiveFlags = (data: string[][]): string[][] => {
  const sensitiveData = ['--phrase', '--ssid', '--password'];
@@ -55,7 +56,10 @@ export default class BinaryConfigurator {
  if (subType.toLocaleLowerCase().includes('tx_')) {
  flags.push(['--tx']);
  }
- flags.push(...this.userDefinesToFlags(params.userDefines));
+
+ if (params.userDefinesMode === UserDefinesMode.UserInterface) {
+ flags.push(...this.userDefinesToFlags(params.userDefines));
+ }
 
  if (params.forceFlash) {
  flags.push(['--force']);