Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error and pass actual entered baud rate #634

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

gbisaga
Copy link
Contributor

@gbisaga gbisaga commented Jul 12, 2024

Fixes issues 626 and 630.

Sorry for all the import thrashing. I have VSC set up to automatically reorder according to eslint rules. If you want me to manually back those out, I can.

src/api/src/graphql/inputs/SerialConnectionConfigInput.ts Outdated Show resolved Hide resolved
src/api/src/graphql/resolvers/SerialMonitor.resolver.ts Outdated Show resolved Hide resolved
src/api/src/services/BinaryFlashingStrategy/index.ts Outdated Show resolved Hide resolved
src/api/src/services/BinaryFlashingStrategy/index.ts Outdated Show resolved Hide resolved
src/main/main.ts Outdated Show resolved Hide resolved
@gbisaga
Copy link
Contributor Author

gbisaga commented Jul 17, 2024

I think it's all fixed now.

Copy link
Member

@jurgelenas jurgelenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jurgelenas jurgelenas merged commit 41df250 into ExpressLRS:master Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants