Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move advanced user defines to expert mode #679

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Move advanced user defines to expert mode #679

merged 2 commits into from
Sep 16, 2024

Conversation

jurgelenas
Copy link
Member

@jurgelenas jurgelenas commented Sep 15, 2024 •
edited
Loading

  • Handle UART_INVERTED warning when expert mode is off
  • When expert mode is off, "expert mode" only user defines should retain their safe default values

@JyeSmith
Copy link
Member

I dont think UART_INVERTED is required because auto baud detection checks for it. @pkendall64 should be able to confirm.

@jurgelenas
Copy link
Member Author

I dont think UART_INVERTED is required because auto baud detection checks for it. @pkendall64 should be able to confirm.

Just for record purposes - this option can removed for ESP32 devices only.

@jurgelenas jurgelenas marked this pull request as ready for review September 16, 2024 21:09
@jurgelenas jurgelenas merged commit 604124d into master Sep 16, 2024
1 of 3 checks passed
@jurgelenas jurgelenas deleted the expert-mode-user-defines branch September 16, 2024 21:09
@jurgelenas jurgelenas changed the title Some user defines should be available in expert mode only Move advanced user defines to expert mode Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurgelenas @JyeSmith