Added non-generic versions of EnableImplicitTypingFrom* methods
#494
Conversation
|
✅ Build ExtendedXmlSerializer 3.5.0.1-kdcgnutf completed (commit fb0f329858 by @netaques) Install it by running the following command in Package Manager Console: Problems with the above command? You may be running into this known issue here: |
|
Cool! Thank you for your contribution @netaques. It appears that this cannot be automatically rebased. Are you able to rebase to master on your end and cherry-pick this commit? I am unclear on how to do this on my end without having to create a new PR. |
|
✅ Build ExtendedXmlSerializer 3.5.0.1-qlvykcgm completed (commit fde651d441 by @netaques) Install it by running the following command in Package Manager Console: Problems with the above command? You may be running into this known issue here: |
|
@Mike-E-angelo my fork should be rebased now, let me know if there are any other issues please. |
|
Ok great... now that that has been resolved. 😁 The reward for diligent work is more diligent work. 😁 Since you've ripped the wrapping off the one method, would you be interested in rounding out the others? I think it would make sense to have the equivalents for the other methods as well:
No worries if not, but thought I would ask before I went and did it myself. :) |
|
Sure, that sounds reasonable. I can handle that. |
|
✅ Build ExtendedXmlSerializer 3.5.0.1-iedmwdyl completed (commit 1f4925ab88 by @netaques) Install it by running the following command in Package Manager Console: Problems with the above command? You may be running into this known issue here: |
|
I was also thinking about adding another method that would return all public property types of the given type. For example calling this suggested method on type public class Outer
{
public Inner Inner { get; set; }
}
public class Inner
{
public InnerInner InnerInner { get; set; }
}
public class InnerInner
{
}Would you agree with something like that, probably in separate PR? |
Mike-E-angelo
changed the title
EnableImplicitTypingFromPublic extension methodEnableImplicitTypingFrom* methods
That's a fantastic idea! I can't believe I didn't think of it. 😆 Yes let's start a new PR for that and we can take it from there. Thanks again for your contribution! We'll get this out next Tuesday. 👍 |
Current implementation of
EnableImplicitTypingFromPublicallows to pass type as a generic parameter only. I have created non-generic variant that takesTypeas ordinary parameter instead of generic.