Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and code improvements #276

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fixes and code improvements #276

merged 1 commit into from
Jul 30, 2024

Conversation

Martinski4GitHub
Copy link
Collaborator

  • Fixed a couple of "variable not set" errors.
  • Fixed a function not having proper return codes.
  • Fine-tuning and code improvements.

@Martinski4GitHub
Fixes and code improvements
92697ef 
- Fixed a couple of "variable not set" errors.
- Fixed a function not having proper return codes.
- Fine-tuning and code improvements.
@Martinski4GitHub
Copy link
Collaborator Author

@ExtremeFiretop,

Please review & run testing & verification for this PR whenever you have the time. I've tested & validated as much as I could, but a 2nd pair of eyes never hurts, of course. :>)

@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Jul 30, 2024 •
edited
Loading

  • Fixed a couple of "variable not set" errors.

Can you point this out for me?
Lots of small changes that drown out the important one lol!

@Martinski4GitHub
Copy link
Collaborator Author

  • Fixed a couple of "variable not set" errors.

Can you point this out for me? Lots of small changes that drown out the important one lol!

I was about to go to bed when I saw your message, LOL!!
I'll add comments to the respective lines on your PR #275 (easier to point them out).

@ExtremeFiretop ExtremeFiretop merged commit bd0852f into ExtremeFiretop:dev Jul 30, 2024
1 check passed
@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Jul 30, 2024 •
edited
Loading

All great catches @Martinski4GitHub ! Especially the unset variable!
All the other improvements are much appreciated as well! :)

@ExtremeFiretop
Copy link
Owner

(easier to point them out).

So you feel my struggle? 🤣
All tested well so far!

@ExtremeFiretop
Copy link
Owner

Synced with Gnuton is commit: 1b018f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExtremeFiretop ExtremeFiretop ExtremeFiretop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martinski4GitHub @ExtremeFiretop