Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minimum Version to 3004.386.12.6 #305

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented Oct 2, 2024

Update Minimum Version to 3004.386.12.6, our minimum version is currently 6 versions behind production or about 8 months behind production. Upping to 3 versions behind production. Last update in this regard was about 10 months ago.

Update Minimum Version, our minimum version is currently 6 versions behind production. Upping to 3 versions behind production. Last update in this regard was about 10 months ago.
@ExtremeFiretop ExtremeFiretop marked this pull request as ready for review October 2, 2024 11:50
@ExtremeFiretop ExtremeFiretop added the dependencies Pull requests that update a dependency file label Oct 2, 2024
@ExtremeFiretop ExtremeFiretop merged commit 794a74f into dev Oct 2, 2024
1 check passed
@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-UppedMinimum branch October 2, 2024 11:55
@ExtremeFiretop ExtremeFiretop changed the title Update Minimum Version Update Minimum Version to 3004.386.12.6 Oct 2, 2024
@Martinski4GitHub
Copy link
Collaborator

Update Minimum Version to 3004.386.12.6, our minimum version is currently 6 versions behind production or about 8 months behind production. Upping to 3 versions behind production. Last update in this regard was about 10 months ago.

With this new "Minimum Version" supported, users that happen to be running F/W versions below 3004.386.12.6 but above 3004.386.11.0 would not be able to update to the latest 3004.386.14.0 version.

What are the concerns if these users were still allowed to do the F/W update via MerlinAU?

Is the main concern due to the big jump/gap between the F/W versions?

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Oct 3, 2024

What are the concerns if these users were still allowed to do the F/W update via MerlinAU?

Is the main concern due to the big jump/gap between the F/W versions?

Exactly.

The intention of MerlinAU was always to keep a router up to date, not to be used to bring a router up to date over large version gaps. This was initially discussed in the forums when I was seeking feedback on the Addon.

I've always wanted to keep fairly close minimum version due to this.

The minimum version I see as dual purpose, it can be used when a specific firmware version is required for a successful update, but I don't believe that's happened recently, the second purpose is to be used to discourage users to install MerlinAU and use it to do one time flashes over many firmware versions.

Specific discussions comments were found here for reference:

Post in thread 'Seeking Feedback & Contributions: Merlin Auto Update Solutions' https://www.snbforums.com/threads/seeking-feedback-contributions-merlin-auto-update-solutions.87044/post-868605

Post in thread 'Seeking Feedback & Contributions: Merlin Auto Update Solutions' https://www.snbforums.com/threads/seeking-feedback-contributions-merlin-auto-update-solutions.87044/post-868608

@Martinski4GitHub
Copy link
Collaborator

What are the concerns if these users were still allowed to do the F/W update via MerlinAU?
Is the main concern due to the big jump/gap between the F/W versions?

Exactly.

The intention of MerlinAU was always to keep a router up to date, not to be used to bring a router up to date over large version gaps. This was initially discussed in the forums when I was seeking feedback on the Addon.

I've always wanted to keep fairly close minimum version due to this.

The minimum version I see as dual purpose, it can be used when a specific firmware version is required for a successful update, but I don't believe that's happened recently, the second purpose is to be used to discourage users to install MerlinAU and use it to do one time flashes over many firmware versions.

Yeah, I see. If that's the case, then what about the 3004.388.xx version series?
There's no "minimum version" check for it even though the first version came out on Dec-2022.
IOW, a user running F/W version 3004.388.1.0 can still update to the latest 3004.388.8_2 (9 versions later, ~21 months apart). Should there be a minimum check for 3004.388.xx as well?

@ExtremeFiretop
Copy link
Owner Author

What are the concerns if these users were still allowed to do the F/W update via MerlinAU?
Is the main concern due to the big jump/gap between the F/W versions?

Exactly.
The intention of MerlinAU was always to keep a router up to date, not to be used to bring a router up to date over large version gaps. This was initially discussed in the forums when I was seeking feedback on the Addon.
I've always wanted to keep fairly close minimum version due to this.
The minimum version I see as dual purpose, it can be used when a specific firmware version is required for a successful update, but I don't believe that's happened recently, the second purpose is to be used to discourage users to install MerlinAU and use it to do one time flashes over many firmware versions.

Yeah, I see. If that's the case, then what about the 3004.388.xx version series? There's no "minimum version" check for it even though the first version came out on Dec-2022. IOW, a user running F/W version 3004.388.1.0 can still update to the latest 3004.388.8_2 (9 versions later, ~21 months apart). Should there be a minimum check for 3004.388.xx as well?

I never considered separating the branch versions with their own checks, but it's not a bad idea at all.

I just didn't want to bump to 388 when we still support two AC routers on 386 technically... But if we split it up then we could have a minimum for each... I like the idea the more I think about it.

@Martinski4GitHub
Copy link
Collaborator

What are the concerns if these users were still allowed to do the F/W update via MerlinAU?
Is the main concern due to the big jump/gap between the F/W versions?

Exactly.
The intention of MerlinAU was always to keep a router up to date, not to be used to bring a router up to date over large version gaps. This was initially discussed in the forums when I was seeking feedback on the Addon.
I've always wanted to keep fairly close minimum version due to this.
The minimum version I see as dual purpose, it can be used when a specific firmware version is required for a successful update, but I don't believe that's happened recently, the second purpose is to be used to discourage users to install MerlinAU and use it to do one time flashes over many firmware versions.

Yeah, I see. If that's the case, then what about the 3004.388.xx version series? There's no "minimum version" check for it even though the first version came out on Dec-2022. IOW, a user running F/W version 3004.388.1.0 can still update to the latest 3004.388.8_2 (9 versions later, ~21 months apart). Should there be a minimum check for 3004.388.xx as well?

I never considered separating the branch versions with their own checks, but it's not a bad idea at all.

I just didn't want to bump to 388 when we still support two AC routers on 386 technically... But if we split it up then we could have a minimum for each... I like the idea the more I think about it.

I think at some point, we'll have to "split" the current 3 branches (3004.386.x, 3004.388.x & 3006.102.x) in order to run a "minimum version" check for each, as appropriate for the router, but taking into account that for some routers it might be possible to go from one branch to the next (e.g. from 3004.388.x to 3006.102.x). Something to consider... :>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants