-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline Version Regex #342
Conversation
Changes made to the regex of the offline version detection to be more in line with what MerlinAU expects.
Problem was identified when flashing the latest offline beta; it still detected it as failed when it wasn't post flash as per the below email: The reason is the format versions don't match, post install it's looking for version: 3006.102.2.0_beta1 but pre-flash it automatically detected the zip file as: 3006.102.2.beta1 This difference in formatting is what is causing the post-flash email to say it failed when it didn't. |
Based on your screenshots & your testing results, your changes are working well. At the moment, I have no way to test this myself with an actual Alpha or Beta release (none available for my router). I reviewed the changes and they all look good to me. If you're completely happy with your latest results at this point, I'd say let's merge them. |
No worries! I also tried the old format with this these changes and it correctly tags them as incorrectly formatted. So I'm pretty happy with this, seems to work correctly :) should be better than production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
BTW, I'm slowly starting to think more seriously about looking for a replacement for my current ASUS router within the next 2 to 3 months, so I'm still not in a rush. My AC-class router is still working fine without any issues so far, and it does meet my current needs, but the lack of F/W updates starting next year is not a good place to be. A friend of mine recommended taking a look at the Firewalla brand, particularly the Firewalla Purple model which, based on the specs, looks good and should meet my home network needs. https://firewalla.com/products/firewalla-purple Do you happen to have any friends or relatives who have it and can provide some technical assessment based on their experience with it? I know of only one person who has one, but it's the Firewall Purple SE so not quite the same. So far, he's happy with it but he's not a computer-savvy person so cannot provide more technical details that I'm looking for. Anyway, just FYI, in case you know someone. |
It's so cute!!! 🥺 I would need to ask around the office, I already know off the top of my head 2 of my techy friends have Ubiquiti and 2 of my friends also have ASUS routers. I don't know anyone off the top of my head that uses this but I'll be sure to poke around haha! I understand the concern of being near end of life with your AC class router, it's probably time to research some good options. Can I ask what type of requirements your looking for? Any reason you aren't looking at Ubiquiti or ASUS? |
Typo correction, my phone has no idea what "Ubiquiti" meant lol |
I'm just researching options at this point, including ASUS but, IMO, the prices of their latest BE-class routers cannot be justified given how immature & inconsistent their 3006 F/W still is (based on RMerlin's assessment from a recent post). I'm looking at Ubiquiti as well and a friend of mine has one, so I'm going to meet with him and ask for more technical details. WRT requirements, I'm looking for an AX-class router (minimum) that meets or exceeds the H/W specs of something like the RT-AX86U PRO, WRT RAM & CPU. Small footprint preferred. Maximum price ~$500 USD & must allow adding custom scripting & tools (like Entware) to customize services. Must have OpenVPN & Wireguard, and any other extras are welcome (e.g. SPI, DPI, etc.). That's the general wish list, but more may come as I do more research. I'm not expecting to make a final decision until perhaps January 2025, unless I find a really good promotion during the Christmas season that would be hard to pass up for the "right" device. Anyway, as mentioned, I'm not yet in a rush, so don't worry about getting info right away. Take your time; I'm sure taking my time as well. Thanks, bud. |
I know what you mean!! I really hate it when my "smart device" thinks it's a better speller than I am and makes "corrections" as I type. 😠🤨 Arghh!! |
I hear you on that one! It's nice routers, but hard to imagine I spent as much money as I did on it. And I'm not sure if it's because of WiFi 7 but my 6GHz range on the new router is much much worse than the 6GHz of my older AXE11000. Not sure why |
Changes made to the regex of the offline version detection to be more in line with what MerlinAU expects.