Code Improvements #357
Code Improvements #357
Conversation
Code improvements, fine-tuning and a fix.
|
OK. I'm done with my changes. Please review as needed. I have nothing else to add for this release, so whenever you're ready, feel free to issue the production release. We had a very good, productive weekend, I'd say. :>). P.S. |
| @@ -6462,14 +6467,16 @@ _PostRebootRunNow_() | |||
| #-------------------------------------------------------------- | |||
| while [ "$curWaitDelaySecs" -lt "$maxWaitDelaySecs" ] | |||
| do | |||
| if _WAN_IsConnected_ && \ | |||
| [ -d "$FW_ZIP_BASE_DIR" ] && \ | |||
| if [ -d "$FW_ZIP_BASE_DIR" ] && \ | |||
There was a problem hiding this comment.
Lool! I didn't even notice this was still here
|
Approved and good to go! |
Currently playing some Minecraft with the Girlfriend but I'll issue a production releases in the next half hour or so, I have to finish building this stone house and then I'll start updating the forms post, etc! :)
Agreed! Some good troubleshooting on some tricky issues. Probably would of gone unreported by most for a while but we nailed it down in the end!
Just what I like to hear! 😌 I mean, did it take a bit of guess work and testing to get it all down, yes, but we got there! And that's always what matters in the end. |
No worries, bud. Enjoy your time with your girlfriend. Those moments are a part of what keeps a relationship healthy & happy.
Yeah, those issues that happen during reboot can be difficult to catch & debug because so many other processes are starting up at the same time, plus whatever other add-ons the user may have installed, and any interaction between them can change the dynamics, the flow, and the timing of the boot sequence. But, yeah, I think we nailed this one.
Not to brag, but our shell script has the cleanest code of all the other scripts I have seen/reviewed from the SNB Forums, by far. |
I'm done with the stone house haha!
I've be VERY surprised if someone said they still had issues; we nailed it down good ;) More like screwed it down through 3 boards. It ain't going nowhere. ;)
Why do you think I only ever want to work on our script? LOL I've looked at many of the other scripts, maybe it's just because I've so involved with this one, but it takes so much more work to decode whats going on compares to ours. Issue comes up? Following the code here is like music to my ears how clean it is! |
|
If I could add anymore positive reactions to that last post, I would! |
👍👍👍 |
Yep, it's screwed in & nailed tight - with 10-inch nails & screws :>) LOL.
Yeah, I hear you. IMO, the 2nd cleanest scripts that I've seen are from Jack Yaz. It's not a close 2nd, but his scripts are fairly clean so it didn't take me long before I understood his code and the logic. Everyone else's that I've seen are miles away from that which makes them more difficult to work with. |
Code improvements, fine-tuning, and a fix.