Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32/add loader to join-production #41

Merged
merged 11 commits into from
Apr 10, 2024
Merged

32/add loader to join-production #41

merged 11 commits into from
Apr 10, 2024

Conversation

malmen237
Copy link
Contributor

No description provided.

@malmen237 malmen237 self-assigned this Apr 5, 2024
@malmen237 malmen237 linked an issue Apr 8, 2024 that may be closed by this pull request
Show loading indicator when joining a production line #32
Closed
martinstark
martinstark requested changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@martinstark martinstark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good over all, I tested it locally. Some minor thoughts on the local state, and a TODO for future error handling

src/components/production-line/production-line.tsx Outdated Show resolved Hide resolved
src/components/production-line/production-line.tsx Outdated Show resolved Hide resolved
src/components/production-line/production-line.tsx Outdated Show resolved Hide resolved
martinstark
martinstark approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@martinstark martinstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@malmen237 malmen237 merged commit dd64964 into main Apr 10, 2024
2 checks passed
@malmen237 malmen237 deleted the feat/add-loader branch April 10, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinstark martinstark martinstark approved these changes

Assignees

@malmen237 malmen237

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show loading indicator when joining a production line
2 participants
@malmen237 @martinstark