Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add better attribute parsing helper function #23

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Nfrederiksen
Copy link

Issue: When parsing an attribute which may have a value that is comma-separated string, the current version cuts of parts of that value. eg. a line like #EXT-X-DATERANGE:ID="2",CLASS="com.apple.hls.interstitial",CUE="PRE,POST" would be parsed as

{
ID: "2",
CLASS: "com.apple.hls.interstitial",
CUE: "PRE" // expecting "PRE,POST"
}

This is due to the original parsing logic splits in "," first.

This PR fixes this by adding a better and more accurate parser function.

@Nfrederiksen Nfrederiksen merged commit cead759 into master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant