Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON Schema and typescript-json-schema Configs #9

Merged

Conversation

Nfrederiksen
Copy link
Contributor

This PR resolves #8
It will add some flags to the typescript-json-schema tool to ensure that it generates a JSON schema with
required and additionalParameters fields and does not use allOf.

These fields are necessary for the Ajv validator (in the EPAS Eventsink) to act as strictly as possible. Without them, the validator would be too lenient, and would rarely invalidate.

Copy link
Contributor

@bwallberg bwallberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nfrederiksen Nfrederiksen merged commit 1b22a57 into main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JSON Schema and Generator
2 participants