fix #261: validate all dependencies are defined

F1bonacc1 · Oct 10, 2024 · 6b724f8 · 6b724f8
1 parent bc0a228
commit 6b724f8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/loader/loader.go b/src/loader/loader.go
@@ -58,6 +58,7 @@ func Load(opts *LoaderOptions) (*types.Project, error) {
 		validateProcessConfig,
 		validateNoCircularDependencies,
 		validateShellConfig,
+        validateDependenciesExist,
 		validatePlatformCompatibility,
 		validateHealthDependencyHasHealthCheck,
 		validateDependencyIsEnabled,

diff --git a/src/loader/validators.go b/src/loader/validators.go
@@ -70,6 +70,18 @@ func validatePlatformCompatibility(p *types.Project) error {
 	return nil
 }
 
+func validateDependenciesExist(p *types.Project) error {
+	for process, config := range p.Processes {
+		for dependency := range config.DependsOn {
+			_, exists := p.Processes[dependency]
+			if !exists {
+				return fmt.Errorf("dependency process '%s' in process '%s' is not defined", dependency, process)
+			}
+		}
+	}
+	return nil
+}
+
 func validateNoCircularDependencies(p *types.Project) error {
 	visited := make(map[string]bool, len(p.Processes))
 	stack := make(map[string]bool)