Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow readiness dependencies to wait through process restarts #189

Closed
shlevy opened this issue May 27, 2024 · 2 comments
Closed

Allow readiness dependencies to wait through process restarts #189

shlevy opened this issue May 27, 2024 · 2 comments
Labels
bug Something isn't working done Done, awaiting release

Comments

@shlevy
Copy link

shlevy commented May 27, 2024

Feature Request

Use Case:

In some cases, a failed readiness probe can only be remedied by a restart, but after healthy restart we want downstream processes to get started

Proposed Change:

Add process_healthy_restart_allowed as a dependency condition, then the process will stay in pending until the process it depends on is healthy (even if restarts are needed) or it will be skipped if the dependent process’s max_restarts are met

Who Benefits From The Change(s)?

Those using crash-only designs

Alternative Approaches

Put the process restart into the process script itself, rather than using process-compose’s orchestration

@F1bonacc1 F1bonacc1 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 8, 2024
@F1bonacc1
Copy link
Owner

Hey @shlevy,

Thanks for reporting this, it should have been the default behavior.
I will deliver a fix in the next version.

@F1bonacc1 F1bonacc1 added the done Done, awaiting release label Jun 9, 2024
@F1bonacc1
Copy link
Owner

Released in v1.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done Done, awaiting release
Projects
None yet
Development

No branches or pull requests

2 participants