Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't shut down process-compose unless requested #200

Closed
zmitchell opened this issue Jul 11, 2024 · 2 comments
Closed

Don't shut down process-compose unless requested #200

zmitchell opened this issue Jul 11, 2024 · 2 comments
Labels
done Done, awaiting release enhancement New feature or request

Comments

@zmitchell
Copy link

Feature Request

Currently process-compose terminates if all the running processes are stopped. I think it would be better if it continued to run until it was requested to shut down.

Use Case:

Suppose you make a config whose processes all terminate unexpectedly (maybe the commands you entered were wrong). You then go to see the status of your processes and get an error because the server has already shut down. If you're using Unix sockets you may even get an unexpected error about a file not existing since process-compose cleans up the socket when it shuts down. The user in this case has no indication as to why process-compose has shut down, or that the root cause it that their processes terminated abruptly.

Proposed Change:

Keep process-compose alive until the user requests that it should terminate.

Who Benefits From The Change(s)?

Anyone running process-compose in the background without the TUI e.g.

$ process-compose up -f <config> -u <path> --tui=false

Alternative Approaches

@zmitchell
Copy link
Author

As a workaround we currently inject a dummy process that simply sleeps forever so that a user can start services again without needing to create a new process-compose instance.

@F1bonacc1 F1bonacc1 added enhancement New feature or request done Done, awaiting release labels Jul 26, 2024
@F1bonacc1
Copy link
Owner

Added in v1.18.0

Cheers ✌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Done, awaiting release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants