-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add memory column #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
A few small comments.
Don't worry about the CI failing. default.nix
will require a vendorHash
update because of the new package.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
How do you fix the nix build? I'm not familiar with it 🤔 |
I will take care of that once I merge. |
Squashed and Merged, thanks again!!! ❤️ |
I think psutil is a useful dependency to add, it opens up a lot of doors for cross-platform process instrumentation. We could potentially add think like CPU percentage and such. (although I'm not sure if it would make sense to squeeze CPU% in there)
Fixes #204