Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add memory column #205

Closed
wants to merge 5 commits into from
Closed

Conversation

themartdev
Copy link
Contributor

I think psutil is a useful dependency to add, it opens up a lot of doors for cross-platform process instrumentation. We could potentially add think like CPU percentage and such. (although I'm not sure if it would make sense to squeeze CPU% in there)

Fixes #204

Copy link
Owner

@F1bonacc1 F1bonacc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
A few small comments.
Don't worry about the CI failing. default.nix will require a vendorHash update because of the new package.

src/app/process.go Outdated Show resolved Hide resolved
src/app/process.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 23, 2024

Copy link
Owner

@F1bonacc1 F1bonacc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@themartdev
Copy link
Contributor Author

How do you fix the nix build? I'm not familiar with it 🤔

@F1bonacc1
Copy link
Owner

How do you fix the nix build? I'm not familiar with it 🤔

I will take care of that once I merge.

F1bonacc1 added a commit that referenced this pull request Jul 25, 2024
@F1bonacc1
Copy link
Owner

Squashed and Merged, thanks again!!! ❤️

@F1bonacc1 F1bonacc1 closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to see process memory footprint
2 participants