Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colour theme choice #2

Closed
6 tasks done
rebecacalvoquintero opened this issue Sep 28, 2017 · 1 comment
Closed
6 tasks done

Colour theme choice #2

rebecacalvoquintero opened this issue Sep 28, 2017 · 1 comment
Assignees
@dangerdak
Labels
awaiting-review priority-2 T1d
Milestone
Milestone 2

Comments

@rebecacalvoquintero
Copy link
Collaborator

rebecacalvoquintero commented Sep 28, 2017 •
edited by dangerdak
Loading

  • As a user I can choose my colour theme
  • The theme will affect the whole app
  • The theme should take effect without having to refresh the page
  • The theme should be the same on my next visit
    • Even without the user having to log in - cookies?
  • Checkbox should be ticked for current theme
@Jen-Harris Jen-Harris added this to the Milestone 1 milestone Sep 28, 2017
@Jen-Harris Jen-Harris mentioned this issue Sep 29, 2017
Closed
@rebecacalvoquintero rebecacalvoquintero self-assigned this Oct 11, 2017
rebecacalvoquintero added a commit that referenced this issue Oct 11, 2017
@rebecacalvoquintero
#2 finished colours of the colour palette
41a724b
rebecacalvoquintero added a commit that referenced this issue Oct 11, 2017
@rebecacalvoquintero
#2 colour switcher function created for the first three colour palettes
74bfdd4
rebecacalvoquintero added a commit that referenced this issue Oct 11, 2017
@rebecacalvoquintero
#2 finished colour palette switcher
0c112cd
@rebecacalvoquintero rebecacalvoquintero mentioned this issue Oct 11, 2017
Merged
1 task
@rebecacalvoquintero rebecacalvoquintero modified the milestones: Milestone 1, MIlestone 2 Oct 11, 2017
@dangerdak
Copy link
Collaborator

dangerdak commented Oct 31, 2017 •
edited
Loading

Alternate stylesheets https://stackoverflow.com/questions/43858633/elegant-way-of-swapping-theme-stylesheets-without-reloading-page

https://alistapart.com/article/alternate

OR set the name of the theme as a class on the body element and use descendent selectors to change colours based on this:

<body class="red-blue">

and

.red-blue .main-background {
  background-colour: red;
}
.red-blue .secondary-background {
  background-colour: blue;
}


.yellow-green .main-background {
  background-colour: yellow;
}
.yellow-green .secondary-background {
  background-colour: green;
}

@dangerdak dangerdak changed the title Colour palette choice Colour theme choice Nov 3, 2017
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Adds theme definitions to css file
c271ed8
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Clicking theme button changes class on body
4af9e47
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Saves and retrieves colour theme using cookies
785782c
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Reduces duplication
2e9b9b6
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Default to unticked circles
1925c1d
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Adds link to home
a791a8f
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Colours were the wrong way around in selector
cebe231
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Ticks box for currently selected colour theme
4e4b55b
dangerdak added a commit that referenced this issue Nov 6, 2017
@dangerdak
#2 Makes colour pallette buttons bounce :)
14a998c
@dangerdak dangerdak mentioned this issue Nov 6, 2017
Merged
dangerdak added a commit that referenced this issue Nov 9, 2017
@dangerdak
#2 Fixes issues from merging
4aa1a16
dangerdak added a commit that referenced this issue Nov 27, 2017
@dangerdak
# This is a combination of 18 commits.
fd5120d 
# This is the 1st commit message:

#10 adds console log for heroku debugging

# The commit message #2 will be skipped:

# #10 increase body parser json limit

# The commit message #3 will be skipped:

# #10 ends /drawing responses

# The commit message #4 will be skipped:

# #10 sets content length

# The commit message #5 will be skipped:

# #10 responds to draw post request

# The commit message #6 will be skipped:

# #10 adds console log for xhr status

# The commit message #7 will be skipped:

# #10 uncomments saveDrawing

# The commit message #8 will be skipped:

# #10 removes debugging lines

# The commit message #9 will be skipped:

# #10 adds debugging lines

# The commit message #10 will be skipped:

# #10 adds more debugging lines

# The commit message #11 will be skipped:

# #10 comments saveDrawing

# The commit message #12 will be skipped:

# #10 comment params

# The commit message #13 will be skipped:

# #10 comment less params

# The commit message #14 will be skipped:

# #10 debugging

# The commit message #15 will be skipped:

# #10 debugging

# The commit message #16 will be skipped:

# #10 debugging

# The commit message #17 will be skipped:

# #10 debugging

# The commit message #18 will be skipped:

# #10 debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dangerdak dangerdak

Labels
awaiting-review priority-2 T1d
Projects
None yet
Milestone
Milestone 2
Development

No branches or pull requests
3 participants
@dangerdak @rebecacalvoquintero @Jen-Harris