Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loads of console.logs #69

Open
ghost opened this issue Mar 31, 2017 · 2 comments
Open

Loads of console.logs #69

ghost opened this issue Mar 31, 2017 · 2 comments
Assignees
@yvonne-liu
Labels
Fixed

Comments

@ghost
Copy link

ghost commented Mar 31, 2017

maybe consider deleting some?
@Jbarget
Copy link

Jbarget commented Mar 31, 2017

@ConchobarMacNessa some links to the lines where the console.logs are would be helpful for the team to make the changes.

Otherwise in a more general case, they have to go around their repo trying to find what you mean

@Jbarget
Copy link

Jbarget commented Mar 31, 2017 •
edited
Loading

There is a crazy amount of logging, will be hard for you to debug when something is actually wrong

screen shot 2017-03-31 at 11 03 52

screen shot 2017-03-31 at 11 03 57

@yvonne-liu yvonne-liu self-assigned this Mar 31, 2017
finnhodgkin added a commit that referenced this issue Mar 31, 2017
@finnhodgkin
added our populate teams module to our build script
397b3e6 
previously our teams kept disappearing when we forgot to run the populate script after the build. Makes sense to combine them...
Also got rid of annoying console.logs in a number of places including the team section
relates to #69
@finnhodgkin finnhodgkin mentioned this issue Mar 31, 2017
Merged
finnhodgkin added a commit that referenced this issue Mar 31, 2017
@finnhodgkin
added validation to the database module rather than within the handler
cc0df41 
relates to #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yvonne-liu yvonne-liu

Labels
Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jbarget @yvonne-liu