maintenance: Bump pydantic to v2 and adapt breaking changes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josumoreno-BP
force-pushed
the
migrate/pydantic
branch
2 times, most recently
from
51562a5 to
48c4201
Compare
|
Thanks for the updates, I will look into testing and cutting a release for this soon. |
|
@robrigo, any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We were using this project but recently we migrated some other project to use pydantic v2 so I'm forced to do so on this one.
The most "controversial" ones could be the change of ref_block_num and ref_block_prefix types to int on
LinkedTransactionbecause it seems they were wrong andArraymodel validator raisingValueErrorinstead ofTypeError(pydantic v1 was allowing it but v2 does not)I also seized the opportunity to group pyproject's dev dependencies into a single group.
Hope you can release a new version with these changes soon.
Thanks