Prevent siloes from cancelling missiles when issued a hard-stop command #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garanas
added
area: ui
Garanas
reviewed
Nov 25, 2024
| @@ -326,8 +318,30 @@ function ClearCommands(units) | |||
| SimCallback(cb, true) | |||
| end | |||
|
|
|||
| -- This command (hard stop) will filter out non-construction silo units to avoid wasting partially completed missiles | |||
| -- Those units will have their commands cleared, but will be paused instead of stopped | |||
| function Stop(units) | |||
There was a problem hiding this comment.
In process of annotating the whole file, will put in separate pr
Garanas
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Stopis moved belowClearCommandsto prevent LLS errors/be next to soft stop. Unnecessary local redefinition ofunitsat the beginning ofStopandSoftStopis removed.Testing done on the proposed changes
Spawn the following units and issue soft- and hard-stop commands. SACUs and ACUs will cancel missile orders when issued a hard-stop command. All other units will pause construction except Yolona (which can't be paused).
Naval unit spawn:
CreateUnitAtMouse('urs0304', 0, -4.50, -0.79, -1.05475)
CreateUnitAtMouse('xss0302', 0, 13.22, 2.00, -0.92170)
CreateUnitAtMouse('uas0304', 0, -11.28, -0.49, -1.09571)
CreateUnitAtMouse('ues0304', 0, 2.56, -0.72, -1.05031)
Land unit and structure spawn:
CreateUnitAtMouse('urb2305', 0, -4.89, -20.43, 0.00000)
CreateUnitAtMouse('xrb0304', 0, -5.89, 18.57, -0.00000)
CreateUnitAtMouse('xrb0304', 0, -7.89, 18.57, -0.00000)
CreateUnitAtMouse('xrb0304', 0, -1.89, 18.57, -0.00000)
CreateUnitAtMouse('xrb0304', 0, -3.89, 18.57, -0.00000)
CreateUnitAtMouse('xsl0001', 0, 3.24, -3.47, 0.00000)
CreateUnitAtMouse('xsl0301', 0, 0.24, -3.47, 0.00000)
CreateUnitAtMouse('uel0001', 0, -2.76, -3.47, 0.00000)
CreateUnitAtMouse('xrb0304', 0, 8.11, 18.57, -0.00000)
CreateUnitAtMouse('xrb0304', 0, 6.11, 18.57, -0.00000)
CreateUnitAtMouse('urb2108', 0, 2.11, -8.43, 0.00000)
CreateUnitAtMouse('xrb0304', 0, 10.11, 18.57, -0.00000)
CreateUnitAtMouse('xsb2305', 0, 4.11, -20.43, 0.00000)
CreateUnitAtMouse('xsb2108', 0, 6.11, -8.43, 0.00000)
CreateUnitAtMouse('uab2305', 0, 13.11, -20.43, 0.00000)
CreateUnitAtMouse('ueb2305', 0, -12.89, -20.43, 0.00000)
CreateUnitAtMouse('xsb2401', 0, 0.11, -29.43, 0.00000)
CreateUnitAtMouse('xrb0304', 0, 4.11, 18.57, -0.00000)
CreateUnitAtMouse('ueb2108', 0, -5.89, -8.43, 0.00000)
CreateUnitAtMouse('uab2108', 0, -1.89, -8.43, 0.00000)
CreateUnitAtMouse('xrb0304', 0, 2.11, 18.57, -0.00000)
CreateUnitAtMouse('xrb0304', 0, 0.11, 18.57, -0.00000)
CreateUnitAtMouse('xab1401', 0, -11.89, -30.43, -0.00000)