Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map-specific options in lobby not appearing #6562

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Nov 28, 2024

Description of the proposed changes

Testing done on the proposed changes

In the lobby, select a map with options such as a survival map; I used /maps/dddx_rpg_survival.v0172/. The map's options should appear at the very bottom of the options list under the "Advanced" section.

The scenario files are cached so a game reload or lobby reload is necessary to reload them and see the changes happen.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

If it ends with slash it doesn't work with the (currently unused) `GetPathToXMask` functions that append strings starting with a slash such as `/lobby/preview-buildable.dds`.
@lL1l1 lL1l1 added type: bug area: lobby related to lobby: options, chat, etc labels Nov 28, 2024
@lL1l1 lL1l1 requested review from Garanas and BlackYps November 28, 2024 23:11
@lL1l1 lL1l1 marked this pull request as ready for review November 28, 2024 23:17
@Garanas Garanas merged commit 3dff3a9 into FAForever:develop Nov 29, 2024
5 checks passed
@lL1l1 lL1l1 deleted the Fix/map-options-select branch December 2, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: lobby related to lobby: options, chat, etc type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants