Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable counterintel by default for AI units #6635

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Jan 25, 2025

Description of the proposed changes

Implements a discord suggestion.

  • Replaces toggles like:
    --Turns Jamming off when unit is built
    self:SetScriptBit('RULEUTC_JammingToggle', true)
    with
    -- Don't turn off jamming for AI so that it uses it by default
    if self.Brain.BrainType == 'Human' then
        self:SetScriptBit('RULEUTC_JammingToggle', true)
    else
        self:SetMaintenanceConsumptionActive()
    end
  • Formatting
  • Annotations

Testing done on the proposed changes

All units work as expected when spawned for the player and the default civilian AI.

Spawn command:
CreateUnitAtMouse('ura0401', 0,    1.93,  115.47,  0.00000)
CreateUnitAtMouse('ura0304', 0,   14.43,  117.47,  0.00000)
CreateUnitAtMouse('uea0304', 1,  -11.18,  -89.86,  0.00000)
CreateUnitAtMouse('uea0304', 1,  -22.74,  -49.33,  0.00000)
CreateUnitAtMouse('uea0304', 1,  -14.93,  -80.66,  0.00000)
CreateUnitAtMouse('xab1401', 0,    1.29,   99.40,  0.00000)
CreateUnitAtMouse('dra0202', 1,   -6.43,  -78.16,  0.00000)
CreateUnitAtMouse('ura0304', 1,   15.07,  -80.66,  0.00000)
CreateUnitAtMouse('xra0305', 1,   28.57,  -81.16,  0.00000)
CreateUnitAtMouse('ura0401', 1,    2.65,  -83.16,  0.16435)
CreateUnitAtMouse('xra0305', 0,   27.93,  116.97,  0.00000)
CreateUnitAtMouse('url0101', 0,  -25.07,  115.97,  0.00000)
CreateUnitAtMouse('ura0303', 1,   23.07,  -81.66,  0.00000)
CreateUnitAtMouse('xsb3201', 1,    3.12,  -67.09, -0.00000)
CreateUnitAtMouse('uea0304', 1,   -7.37,  -78.44,  0.00000)
CreateUnitAtMouse('xab1401', 1,    2.29,  -98.60, -0.00000)
CreateUnitAtMouse('url0101', 1,  -24.43,  -82.16,  0.00000)
CreateUnitAtMouse('uea0304', 1,   -9.34,  -60.59,  0.00000)
CreateUnitAtMouse('ura0303', 0,   22.43,  116.47,  0.00000)
CreateUnitAtMouse('dra0202', 0,   -7.07,  119.97,  0.00000)
CreateUnitAtMouse('uea0304', 0,  -15.57,  117.47,  0.00000)
CreateUnitAtMouse('xsb3201', 0,    1.29,   92.40,  0.00000)

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

lL1l1 added 3 commits January 24, 2025 19:34
URL0101: Cybran land scout cloaking
URAxxx: Cybran aircraft personal stealth
UEA0304: UEF Strat jamming
@lL1l1 lL1l1 added type: enhancement area: AI related to AI functions labels Jan 25, 2025
@lL1l1 lL1l1 added this to the Development Iteration I of 2025 milestone Jan 25, 2025
@lL1l1 lL1l1 marked this pull request as ready for review January 25, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI related to AI functions type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant