Ladder matchmaking at dynamic intervals #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing an infinite loop in the tests when remaining time was less than 0, because the coroutine would never give up control
Askaholic
force-pushed
the
ladder-queue-pop
branch
from
5977633
to
2f5d2e9
Compare
Askaholic
force-pushed
the
ladder-queue-pop
branch
from
e38129f
to
50e2b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #427
These are cherry picked commits of the "queue pop" code that I wrote in #428. This would let us deploy the queue popping for regular ladder 1v1 even before team matchmaking is completely finished.
This PR does NOT contain the team creation code for XvX games.