Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased ttl to relax #482 #483

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Nov 20, 2023

related #482

4 hours cache is better than having an unresponsive leader board.
change my mind

@fcaps fcaps force-pushed the feature/increase-leaderboard-ttl branch from 00881a9 to a0d919e Compare November 20, 2023 04:12
@Brutus5000
Copy link
Member

When I tested it on the freshly deployed website the loading time wasn't even 10 seconds. 4hours TTL is brutal. How about 1 hour?

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 21, 2023

When I tested it on the freshly deployed website the loading time wasn't even 10 seconds. 4hours TTL is brutal. How about 1 hour?

lowered to 1h, this will be gone with m2m anyways.

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 21, 2023

btw. you got any traffic-numbers for me? is this site called 10 or 1000 times per day?

@Brutus5000
Copy link
Member

Brutus5000 commented Nov 21, 2023

Uh such a long time ago that we had measured with plausible. But it was surprisingly high. I think more than 1000 per day.

@fcaps
Copy link
Collaborator Author

fcaps commented Nov 21, 2023

GoogleAnalytics? can see the call to GA

@Brutus5000
Copy link
Member

Due to our privacy policy plausible was the maximum we want to use (or anything selfhosted).

@Brutus5000 Brutus5000 merged commit 7324782 into FAForever:develop Nov 21, 2023
2 checks passed
@fcaps fcaps deleted the feature/increase-leaderboard-ttl branch November 22, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants