Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(account-linking): better error handling #562

Conversation

Ivan-Shaml
Copy link
Member

@Ivan-Shaml Ivan-Shaml commented Jan 8, 2025

Better error handling for Steam and GOG account linking. If error occurs during account linking, now the flash message is being scrolled to, in the viewport, and it gets highlighted

Closes #549

@Ivan-Shaml Ivan-Shaml marked this pull request as draft January 8, 2025 20:16
@Ivan-Shaml Ivan-Shaml marked this pull request as ready for review January 11, 2025 20:49
Brutus5000
Brutus5000 previously approved these changes Jan 23, 2025
Copy link
Member

@Brutus5000 Brutus5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I am to lazy to test this locally.

* better error handling for Steam and GOG account linking. If error occurs during account linking, now the flash message is being scrolled to in the view port, and it gets highlighted
@Ivan-Shaml Ivan-Shaml force-pushed the feat/account-linking-better-error-handling branch from e15b6a7 to 458e57e Compare January 23, 2025 22:32
@Brutus5000 Brutus5000 merged commit 573115c into FAForever:develop Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linking steam account goes wrong
2 participants