Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for using tag weights with L2MAE force loss #439

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Support for using tag weights with L2MAE force loss #439

merged 2 commits into from
Jan 19, 2023

Conversation

abhshkdz
Copy link
Collaborator

Our most recent models (SCN, GemNet*) use L2MAE as the default force loss. This PR adds support for using tag weights with L2MAE.

mshuaibii
mshuaibii approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@mshuaibii mshuaibii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Minor - ForceNet's configs will now be using L2MAE instead of MAE (what it was originally trained on). I don't see a strong reason to change this to accommodate for ForceNet given it's not used. But flagging it here in case you think otherwise.

@abhshkdz abhshkdz merged commit 255c9ef into main Jan 19, 2023
@abhshkdz abhshkdz deleted the l2mae-tagweights branch January 19, 2023 21:58
levineds pushed a commit that referenced this pull request Jul 11, 2024
@abhshkdz
Support for using tag weights with L2MAE force loss (#439)
fbea689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshuaibii mshuaibii mshuaibii approved these changes

@sidgoyal78 sidgoyal78 Awaiting requested review from sidgoyal78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhshkdz @mshuaibii