Config fix #737
Merged
Config fix #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshuaibii
previously approved these changes
Jun 21, 2024
Codecov ReportAttention: Patch coverage is
|
misko
approved these changes
Jun 21, 2024
misko
reviewed
Jun 21, 2024
| "Detected old config, converting to new format. Consider updating to avoid potential incompatibilities." | ||
| ) | ||
|
|
||
| # do we need a copy? |
There was a problem hiding this comment.
@lbluque I think we might, otherwise the underlying config can change. I think i might have seen this somewhere were a notebook or someone was using this directly, without a call through main.py
levineds
pushed a commit
that referenced
this pull request
Jul 11, 2024
* config fix * config compatibility in ase calc * check if eval_metrics is present * handle existing empty loss_functions dicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle updating checkpoints with new format configs that were saved with 'loss_fns' and 'eval_metrics' according to #724