Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log num params to W&B #741

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Log num params to W&B #741

merged 5 commits into from
Jun 26, 2024

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Jun 25, 2024

Log num params to W&B, will useful for scaling law/model size comparisons

Example:
https://fairwandb.org/rgao/fairchem/runs/2024-06-25-22-51-44-main_test/overview

image

@rayg1234 rayg1234 requested review from misko and wood-b and removed request for wood-b June 25, 2024 23:01
misko
misko previously approved these changes Jun 25, 2024
misko
misko previously approved these changes Jun 25, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/fairchem/core/trainers/base_trainer.py 86.49% <100.00%> (+0.03%) ⬆️
src/fairchem/core/common/logger.py 75.00% <54.54%> (-1.20%) ⬇️

@rayg1234 rayg1234 requested a review from misko June 26, 2024 05:15
@rayg1234 rayg1234 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 3d04ca9 Jun 26, 2024
5 checks passed
@rayg1234 rayg1234 deleted the rgao_wb_add_params_summary_metric branch June 26, 2024 16:48
levineds pushed a commit that referenced this pull request Jul 11, 2024
* log num params

* typo

* check logger exists first

* update tb loggers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants