-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to run PBC in single system mode #795
Conversation
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Question though, how do you use pbc_single? Do I need to specify use_pbc_single: True
to the model parameters in the config?
I just pushed those changes! Realized it wasn't connected. The way we connect parameters to generate_graph is a bit interesting! |
There is an issue when running PBC across multiple systems. The current code takes the number of expansions in each direction for the worst case system in each batch. This can result in a very large amount of GPU memory required for expansion 50GB+
This PR adds an option "use_pbc_single" that runs PBC expansion for each system, one at a time.
The runtime is approximately 10% slower for PBC construction, but does not seem significant for the overall runtime.