-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor and deprecate old equiformerv2 #812
Conversation
Codecov ReportAttention: Patch coverage is
|
Thanks for doing this! minor ask: can you also separate the tests to test_equiformers_v2_deprecated and test_equiformers_v2 (https://github.com/FAIR-Chem/fairchem/blob/main/tests/core/models/test_equiformer_v2.py) this way someone can just delete the *deprecated.py without accidentally deleting the activation checkpointing test or new tests on the backbone/hydra only for example |
Moving forward equiformer v2 should be invoked through hydra using both a head and backbone. This moves the original code (required to load from a checkpoint) to a deprecated status.