Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record page tooltips #2305

Merged
merged 30 commits into from
Sep 11, 2024
Merged

Record page tooltips #2305

merged 30 commits into from
Sep 11, 2024

Conversation

knirirr
Copy link
Contributor

@knirirr knirirr commented Apr 29, 2024

Ticket: #2295

@knirirr knirirr changed the title Tooltip not displaying... #2295 Record page tooltips May 1, 2024
@knirirr
Copy link
Contributor Author

knirirr commented May 1, 2024

tweaked the definitions
@allysonlister
Copy link
Contributor

Here is the current view on a screen-maximised version of dryad in both the netlify and prod builds. It seems that every field EXCEPT homepage, year, type and registry are all aligned differently from how they are at present.

Once the alignment is fixed I will approve. In the meantime I have also updated the tooltips slightly here. Did I do that correctly?

Thanks!

Netlify:
Screenshot from 2024-05-13 10-21-19

Prod:
image

@allysonlister
Copy link
Contributor

"maintainers" has an empty tooltip - please could you add the following text for it?

"A list of developers of this resource who have claimed ownership of the record both for attribution and to perform updates the record."

@knirirr
Copy link
Contributor Author

knirirr commented May 20, 2024

Your modification was successful; the application runs locally.
I have added text for maintainers.
I'm aware of the alignment but it's not within my capabilities to fix, unfortunately.

@knirirr knirirr requested a review from prakhyatox May 23, 2024 09:11
@knirirr knirirr requested review from delphinedauga and allysonlister and removed request for allysonlister August 2, 2024 13:20
Copy link
Contributor

@ramGranell ramGranell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two things:

  1. Content of the tooltips:
    I think that the tooltip of Maintainers is missing "to", i.e. "...perform updates to the record.".
    Maybe in the tooltip of "Taxonomic Range" it would be helpful to indicate that this field is only for "Life science related records", i.e. this is not apply to other disciplines instead the name is generic as taxonomies exist in other areas. I suppose that this field is heritage from Biosharing. Writing a thing like "This is only applied to records related to life science."?
  2. When I go the icons of support, organisations, data processes it appears a blue circle with a question mark and expect to have a tooltip but nothing appears. Anyway, this may not be related to this ticket and tooltips.

@allysonlister
Copy link
Contributor

allysonlister commented Aug 29, 2024

I agree with Ramon on his first point.

With regards to his second point, I do not see any tooltips or grey question mark icons outside of the General Information and Cross References. However, note that in the originating ticket I said we can start with the General Information and move to the other sections after that. Given the time constraints for getting started on vue3, can I suggest that a new ticket is spawned from #2295 (comment) that can be given a low, post-vue3 priority please?

Finally, some elements of the General Information tab are still missing "?" below is an example from https://deploy-preview-2305--fairsharing.netlify.app/3495 which shows that Contact, Organisations and Reference URL are missing "?":
Screenshot from 2024-08-29 13-52-49

Please can you carefully go through all possible fields and make sure they have them? The main issue with the screenshot above is that Reference URL is just for collections (and so may easily have been missed), and Contact and Organisation are ONLY added to the General Information when it is a Collection, because Collections don't have the subsections where these elements would normally go.

Thanks!

@knirirr
Copy link
Contributor Author

knirirr commented Aug 29, 2024

I've added the missing sections and corrected the text.
Re. the ticket, I'd think it best to keep the existing one open and to open another PR when there's time to address other parts of the application.

Copy link
Contributor

@allysonlister allysonlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - the update looks good, and happy to progress with the rest of the ticket as you suggest

@knirirr knirirr merged commit 1783f49 into dev Sep 11, 2024
13 checks passed
@knirirr knirirr deleted the record_tooltips_2295 branch September 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants