New context format with JSon schema and two sample data files #2
Conversation
|
@finos-cla-bot[bot] check |
|
Merging this PR, since @lspiro-Tick42 is indeed covered by CLA with FINOS. The CLA Bot is flagging this PR due to (apparently) a configuration issue (see https://github.com/ColinEberhardt/cla-bot/issues/74); we will reproduce the same issue on https://github.com/finos-fdx/odp-test |
|
Mao asked me to add an approve comment since he had to initiate the PR. I have not created a branch, since I don't know what our WG branching policy is. This PR consists of 3 new files so could easily be unwound or moved to a branch if required. |
|
In my opinion this PR should be unmerged as it was never discussed during a working group call. I do not agree with some of the changes added here. |
|
The merge will be undone. Comments welcome on this PR. |
|
Thanks @tkolecke . I'm happy to rollback the Pull Request for you , please let me know if/when to proceed. The last commit before the PR is be60e22 and there are no further commits afterwards, therefore a simple |
|
Rolling back master branch now, on commit be60e22 |
|
Rollback completed, see https://github.com/FDC3/ContextData/commits/master /CC @tkolecke @rikoe |
This Pull request moves the Context data specification to match up with the current Intent definitions by allowing a data item (e.g. Instrument or Contact) to have multiple named formats (instead of just having a single data set with multiple field names).
This structure allows applications to register an Intent to only be relevant for a particular format of Instrument (for example only showing in-house position for an instrument if the Context holds the in-house instrument format )
NB An application Intent can be offered for multiple formats.
The Pull Request provides a JSon schema and two sample data files for this proposal.