fix wasted control_ping_id caching

during a reconnect, when msg table is reset, these fields aren't and crash the vpp next time.
FDio · Jun 19, 2024 · 29451e9 · 29451e9
1 parent 5818b80
commit 29451e9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/connection.go b/core/connection.go
@@ -548,10 +548,10 @@ func (c *Connection) retrieveMessageIDs() (err error) {
 			n++
 			nn++
 
-			if c.pingReqID == 0 && msg.GetMessageName() == c.msgControlPing.GetMessageName() {
+			if msg.GetMessageName() == c.msgControlPing.GetMessageName() {
 				c.pingReqID = msgID
 				c.msgControlPing = reflect.New(reflect.TypeOf(msg).Elem()).Interface().(api.Message)
-			} else if c.pingReplyID == 0 && msg.GetMessageName() == c.msgControlPingReply.GetMessageName() {
+			} else if msg.GetMessageName() == c.msgControlPingReply.GetMessageName() {
 				c.pingReplyID = msgID
 				c.msgControlPingReply = reflect.New(reflect.TypeOf(msg).Elem()).Interface().(api.Message)
 			}