Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for GoVPP CLI #135

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Improvements for GoVPP CLI #135

merged 3 commits into from
Jun 23, 2023

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Jun 13, 2023

  • files are now sorted by name by default
  • added new linter rule MessageSameStatus
  • fixed issue with cache of cloned repository
  • added option --targz for vppapi export command
  • fixed issues with color mode when not using terminal
  • added option to vppapi diff command to include comment differences
  • added --paths option to filter out specific API files or paths

- added new linter rule MessageSameStatus
- fixed issue with cache of cloned repository
- added option --targz for vppapi export command
- fixed issues with color mode when not using terminal
- added option to vppapi diff command to include comment differences
- added --paths option to filter out specific API files or paths

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Copy link
Contributor

@sknat sknat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, lgtm
Just found some commented code inline

cmd/govpp/cmd_vppapi_export.go Outdated Show resolved Hide resolved
cmd/govpp/cmd_vppapi_ls.go Outdated Show resolved Hide resolved
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry added this to the v0.8.0 milestone Jun 21, 2023
Copy link
Contributor

@sknat sknat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Many thanks 😄

@sknat sknat merged commit 21b5292 into master Jun 23, 2023
9 checks passed
@sknat sknat deleted the vppapicli branch June 23, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants