Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: message-box support appendTarget #65

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

DeepenLau
Copy link

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

由于 message-box 目前只能是 append to body,子应用如果需要修改覆盖其默认样式,只能通过 custom-class 写入带 name scoped 的全局 class 名

故拓展该组件,支持传入 插入文档的目标位置

@auto-add-label auto-add-label bot added the enhancement New feature or request label Jun 19, 2020
@lianghx-319
Copy link
Member

不如看看能不能改成支持 shadowDom ?这样应该就可以随行所欲的写样式了

@netlify
Copy link

netlify bot commented Jun 19, 2020

Deploy preview for femessage-element ready!

Built with commit 4453ad3

https://deploy-preview-65--femessage-element.netlify.app

@levy9527
Copy link

😂抱歉现在才来处理。补充个文档吧,让其他人也能学习使用。

@DeepenLau
Copy link
Author

image
已补充文档

@DeepenLau DeepenLau force-pushed the feat/expand-message-box branch from 0f4a2f1 to 4453ad3 Compare August 10, 2020 10:13
@DeepenLau
Copy link
Author

其实如果要采用这个方案的话,那么包括 dialog drawer tooltip 之类的组件都要新增这个api,目前这里只改动了 message-box

@levy9527
Copy link

其实如果要采用这个方案的话,那么包括 dialog drawer tooltip 之类的组件都要新增这个api,目前这里只改动了 message-box

没事,有用到再说。

@levy9527 levy9527 merged commit 9cdf297 into FEMessage:dev Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants